Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow users to override nitro error #58

Merged
merged 8 commits into from
Apr 12, 2022
Merged

fix: allow users to override nitro error #58

merged 8 commits into from
Apr 12, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 8, 2022 •
edited
Loading

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Previously it was impossible to override sub-paths (for example, #nitro/error) as #nitro was added first to the alias object.

Do not yet merge as there is an error that this reveals in Nuxt that needs to be resolved first: resolved in nuxt/framework#4215

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 April 8, 2022 20:35
@pi0
Copy link
Member

pi0 commented Apr 8, 2022

We might use #nitro-* alias for a temporary error alias workaround. I don't think reusing #nitro namespace is best idea in terms of stability.

@danielroe danielroe marked this pull request as ready for review April 8, 2022 21:47
@danielroe danielroe self-assigned this Apr 8, 2022
@danielroe danielroe mentioned this pull request Apr 8, 2022
Merged
7 tasks
@danielroe danielroe changed the title fix: allow users to override #nitro sub-paths fix: allow users to override nitro error Apr 8, 2022
@danielroe danielroe mentioned this pull request Apr 11, 2022
Closed
@pi0 pi0 merged commit aa660c7 into main Apr 12, 2022
@pi0 pi0 deleted the fix/allow-overriding-nitro-aliases branch April 12, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0